Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass DATADEPS_ALWAYS_ACCEPT=true to our CI job #108

Merged
merged 5 commits into from
Mar 25, 2021
Merged

Pass DATADEPS_ALWAYS_ACCEPT=true to our CI job #108

merged 5 commits into from
Mar 25, 2021

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented Mar 12, 2021

Currently, our nice example code is erroring because it can't download the datadeps. This should fix the immediate issues. The longer term fix would be to pass strict=true to makedocs when Documenter is update to error on exception in @repl blocks.

#109

rofinn added 5 commits March 12, 2021 16:32
1. `index.md` symlink to README, so we can doctest the README
2. Use `jldoctest` in README
3. Replace `@repl` with `@example`, so `strict=true` will cause errors during builds.
@rofinn rofinn merged commit 4f31eda into master Mar 25, 2021
@rofinn rofinn deleted the rf/fix-docs branch March 25, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant