Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit keyword to LOCF, NOCB and Interpolation #117

Merged
merged 5 commits into from
Apr 16, 2021
Merged

Add limit keyword to LOCF, NOCB and Interpolation #117

merged 5 commits into from
Apr 16, 2021

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented Apr 15, 2021 •
edited
Loading

Closes #110
Extends #116

TODO:

  • Add limit keyword to Interpolate
  • [ ] Add examples to the functional docstrings
  • [ ] Add a weighted version?

@rofinn rofinn mentioned this pull request Apr 16, 2021
Closed
@rofinn rofinn changed the title WIP: Add limit keyword to LOCF, NOCB and Interpolation Add limit keyword to LOCF, NOCB and Interpolation Apr 16, 2021
@rofinn rofinn requested a review from morris25 April 16, 2021 21:25
morris25
morris25 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@morris25 morris25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rofinn rofinn merged commit 5f688b9 into master Apr 16, 2021
@rofinn rofinn deleted the rf/limit-locf branch April 16, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morris25 morris25 morris25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FillNA limits for Interpolate, NOCB, LOCF
2 participants
@rofinn @morris25