Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat csv #126

Merged
merged 2 commits into from
Jan 22, 2022
Merged

compat csv #126

merged 2 commits into from
Jan 22, 2022

Conversation

mzgubic
Copy link
Contributor

@mzgubic mzgubic commented Jan 21, 2022

and fix the docs

@mzgubic
Copy link
Contributor Author

mzgubic commented Jan 21, 2022 •
edited
Loading

@rofinn I don't think the Documentation job failure is related?

@rofinn
Copy link
Member

rofinn commented Jan 21, 2022

Yeah, it's a bug in the AxisKeys printing code. My vote would be to pin the documentation build to Julia LTS which is 1.6 now.

@mzgubic
Copy link
Contributor Author

mzgubic commented Jan 21, 2022 •
edited
Loading

thanks, looks like the job passes now. good to merge? Also, if you could merge that would be great, I am not authorized apparently 🤷

@rofinn
Copy link
Member

rofinn commented Jan 22, 2022

Yep, looks good to me. Thanks!

@rofinn rofinn merged commit 9230661 into master Jan 22, 2022
@rofinn rofinn deleted the mz/csv branch January 22, 2022 22:21
@rofinn rofinn mentioned this pull request Jan 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzgubic @rofinn