Fixes compatibility for tests running against Juliav1.8 #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
Impute.jl
tests against Julia1.8, we run into a problem when calling thenrmsd()
function here (fromDistances.jl
, function found here).There error we get is as follows:
Since there were some changes/refactoring to the
extrema()
function, it created aMethodError
, where it couldn't match theadjoint()
method with what we passed in (adjoint(data)
from within the failing test).Flipping the two around fixes the tests, but not the root of the problem. I'm not sure if this is the correct solution, or if I have to report this as an issue with
JuliaLang
itself. I know a bunch of other stuff changed aroundmapping
, so maybe this isn't a problem here, but a new limitation with the language itself.Happy to hear some feedback about this :)