Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compatibility for tests running against Juliav1.8 #131

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

BaileyBox
Copy link

When running Impute.jl tests against Julia1.8, we run into a problem when calling the nrmsd() function here (from Distances.jl, function found here).

There error we get is as follows:

Screen Shot 2022-10-03 at 4 01 26 PM

Since there were some changes/refactoring to the extrema() function, it created a MethodError, where it couldn't match the adjoint() method with what we passed in (adjoint(data) from within the failing test).

Flipping the two around fixes the tests, but not the root of the problem. I'm not sure if this is the correct solution, or if I have to report this as an issue with JuliaLang itself. I know a bunch of other stuff changed around mapping, so maybe this isn't a problem here, but a new limitation with the language itself.

Happy to hear some feedback about this :)

@BaileyBox
Copy link
Author

@rofinn is it correct to swap these 2 around to fix this? Or should I try to find another solution (Reporting bug to JuliaLang)?

Copy link
Member

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit annoying that it needs to change, but this seems fine to just modify the tests. It doesn't impact the actually functionality, so make sure to remove the version bump.

Project.toml Outdated Show resolved Hide resolved
@BaileyBox
Copy link
Author

I'm unsure why the x64 julia check failed, when the exact same test passed previously.

@rofinn rofinn merged commit 7d643ff into master Oct 19, 2022
@rofinn rofinn deleted the bs/fixes-test-compatibility branch October 19, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants