Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MassInstallAction: Install the GitHubActions workflow on this repository #95

Merged
merged 6 commits into from
Dec 14, 2020

Conversation

fchorney
Copy link
Member

@fchorney fchorney commented Dec 4, 2020

This pull request sets up the GitHubActions workflow on this repository. cc: @fchorney

Copy link
Member

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs to be rebased and possibly a couple changes made.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@fchorney fchorney force-pushed the massinstallaction/set-up-GitHubActions branch from 077a866 to 16e1bcf Compare December 14, 2020 18:04
@fchorney fchorney force-pushed the massinstallaction/set-up-GitHubActions branch from e82f51e to 985b969 Compare December 14, 2020 18:06
@rofinn
Copy link
Member

rofinn commented Dec 14, 2020

Should be good to merge. 1.0 error seems to be a known issue with Pkg on the LTS release.

@fchorney
Copy link
Member Author

Should be good to merge. 1.0 error seems to be a known issue with Pkg on the LTS release.

Should we potentially turn off 1.0 testing on here then? as when it runs overnight, we will get spammed with 1.0 fails on the slack.

@rofinn
Copy link
Member

rofinn commented Dec 14, 2020

I'd be fine with turning of 1.0.5 builds, though I don't think the Pkg error is consistent.

@fchorney
Copy link
Member Author

I'd be fine with turning of 1.0.5 builds, though I don't think the Pkg error is consistent.

if it's not consistent then we can leve them for now, but if it continues we can turn them off

@fchorney fchorney merged commit c12438f into master Dec 14, 2020
@fchorney fchorney deleted the massinstallaction/set-up-GitHubActions branch December 14, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants