global: initial refactoring #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Authors | ||
| ======= | ||
|
|
||
| Invenio module that implements OAuth 2 server. | ||
|
|
||
| - Charlotte Cattaneo <[email protected]> |
There was a problem hiding this comment.
Authors should not be removed.
jirikuncar
changed the title
|
@lnielsen sure this is WIP as @SamiHiltunen was struggling with rebasing his work. |
|
@lnielsen Yes, this is very much work in progress. @jirikuncar please do not pull unfinished work from my fork and call it 'struggling with rebasing'. |
|
@SamiHiltunen I'm sorry, I had some updates to share and there was no prior PR with your work. |
| # FIXME new oauthlib release after 0.7.2 has some compatible problems with | ||
| # the used Flask-Oauthlib version. | ||
| tests_require = [ | ||
| 'Flask-httpretty>=1.2.0', |
There was a problem hiding this comment.
@SamiHiltunen 1.3.0 has been just released 🎆 (see https://pypi.python.org/pypi/Flask-httpretty)
6 tasks
jirikuncar
force-pushed
the
next
branch
3 times, most recently
from
8d54b33 to
4e6c0ee
Compare
jirikuncar
force-pushed
the
next
branch
4 times, most recently
from
c8068fe to
ac97ed2
Compare
|
|
||
| import six | ||
|
|
||
| from invenio_db import db | ||
| from sqlalchemy_utils.types import URLType | ||
| from sqlalchemy_utils.types.encrypted import AesEngine, EncryptedType |
There was a problem hiding this comment.
Not something for now, but we should pay attention to this one kvesteri/sqlalchemy-utils#166
jirikuncar
force-pushed
the
next
branch
9 times, most recently
from
528527d to
c86c9ae
Compare
jirikuncar
changed the title
jirikuncar
force-pushed
the
next
branch
2 times, most recently
from
e4f3939 to
d1a49f6
Compare
Co-authored-by: Sami Hiltunen <[email protected]> Signed-by: Jiri Kuncar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/test_provider.pycc @lnielsen