-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninstall adapter from package-lock.json only before re-installing tarball #613
Conversation
…but will re-use a cached version ioBroker#612
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this is also not working as intended. According to https://docs.npmjs.com/cli/v10/commands/npm-update, this will update all installed packages to their latest version, including js-controller, admin and the adapter's dependencies.
I think the best solution for now is to rename the tarball to something random, so npm always installs it
@AlCalzone Renaming the tarball wouldn't help. I have found another solution:
The advantage:
If this is a feasible solution I can change this pull request accordingly. |
Why using --pachage-lock-only? The adapter will be installed afterwards anyway. And removing any rest of the adapter can only improve testing. |
That would uninstall the dependencies, too. |
Ok would cause some time. But would ensure to install deps exactly as listed in package.json. if changed.Pro and contra. But yes could be too much overhead for major Situations |
@MiSchroe I think it is worth a shot |
…move the adapter from the package-lock.json file(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor thing. I assume that you've tested this locally?
Fixes #612