Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to unicast the WOL packet. Needed if sender and TV are on different subnets. #289

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

uKL
Copy link

@uKL uKL commented Dec 26, 2024

In some cases (like mine) where the issuing device and TV are on different subnets/vlans, for the routing of the packet to take place, it must be given the destination IP address. The library that is used allows such configuration so it was pretty easy.

Tested on OLED65C45LA.DEUQLJP and Tp Link Omada network stack.

@mcm1957
Copy link
Member

mcm1957 commented Dec 26, 2024

Thanks
Will check / merge / relese the nex days.

@mcm1957 mcm1957 merged commit 55d3b31 into iobroker-community-adapters:master Dec 27, 2024
10 checks passed
@mcm1957
Copy link
Member

mcm1957 commented Dec 27, 2024

v2.4.0 should be available at latest repository tomorrow.
Please test the version adn let me now (best at forum - https://forum.iobroker.net/topic/68724/test-adapter-lgtv-v2-3-x ) if everythiung is working as expected.

THANKS for you support and PR.

@uKL
Copy link
Author

uKL commented Dec 29, 2024

I think I will follow up with one more, to separate IP address setting for WOL. From my further testing, broadcast based on the unicast IP address is subject to the switch ARP table cache. Once the entry is gone, it will no longer forward to a specific port. In that cases the subnet-directed broadcast may do the trick.

@mcm1957
Copy link
Member

mcm1957 commented Dec 29, 2024

Youre welcome with any improvement / fix.
THANKS for spending your time an d knowlegde.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants