Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to restrict API to authenticated only #1926

Merged
merged 8 commits into from
Jun 12, 2019
Merged

Add ability to restrict API to authenticated only #1926

merged 8 commits into from
Jun 12, 2019

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Jun 11, 2019 •
edited
Loading

Fix #1879.

Pull Request checklist

  • Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • Tests: This PR includes thorough tests or an explanation of why it does not

@jezdez jezdez requested a review from wlach June 11, 2019 16:31
@jezdez
Copy link
Contributor Author

jezdez commented Jun 11, 2019

Tests upcoming... 😬

wlach
wlach reviewed Jun 11, 2019
View reviewed changes
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests would be great! Could you submit another PR to make sure we do a flake8 test as well?

server/tests/test_jwt_authentication.py Outdated Show resolved Hide resolved
@jezdez jezdez mentioned this pull request Jun 12, 2019
Merged
3 tasks
@jezdez jezdez requested a review from wlach June 12, 2019 14:04
wlach
wlach approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a black linter error. Aside from that, looks good to me!

@jezdez
Copy link
Contributor Author

jezdez commented Jun 12, 2019

There seems to be a black linter error. Aside from that, looks good to me!

Yeah, there is PyCQA/isort#694 that documents a incompatibility of isort and black in their default configuration. Luckily there is a workaround.

@jezdez jezdez merged commit 1f2ad33 into master Jun 12, 2019
@jezdez jezdez deleted the restrict-api branch June 12, 2019 18:28
@wlach wlach mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlach wlach wlach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow completely restricting /api/ endpoints to those with authorization
2 participants
@jezdez @wlach