Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS S3 or HTTP storage #160

Open
vincentsarago opened this issue Feb 5, 2020 · 4 comments · May be fixed by #161
Open

Add AWS S3 or HTTP storage #160

vincentsarago opened this issue Feb 5, 2020 · 4 comments · May be fixed by #161

Comments

@vincentsarago
Copy link

👋 First thanks for this awesome library 🙏

I was wondering if adding AWS S3 or simple HTTP storage would be something worth implementing here.

I could start a PR if 👌

Thanks
@vincentsarago vincentsarago linked a pull request Feb 5, 2020 that will close this issue
Open
1 task
@ionelmc
Copy link
Owner

ionelmc commented Feb 5, 2020

Ah yes, extra storages are welcome. Take a look at the elastic search storage for testing ideas.

@vincentsarago
Copy link
Author

👍 excellent!
I did look at the elasticsearch test suite, I'll see if I can finish later today

@vincentsarago
Copy link
Author

@ionelmc I'm sorry for letting this stale, I'll try to come back to it this week

@ionelmc
Copy link
Owner

ionelmc commented Feb 24, 2020

If you got any questions about the current implementation just ask. I'd expect some things to be non-obvious as the internals are not really documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add S3Storage vincentsarago/pytest-benchmark
2 participants
@ionelmc @vincentsarago