Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add S3Storage #161

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

vincentsarago
Copy link

@vincentsarago vincentsarago commented Feb 5, 2020

closes #160

To Do

  • write tests

cc @ionelmc

@vincentsarago vincentsarago marked this pull request as ready for review March 23, 2020 02:15
@codecov-io
Copy link

Codecov Report

Merging #161 into master will decrease coverage by 35.26%.
The diff coverage is 13.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #161       +/-   ##
===========================================
- Coverage    67.8%   32.53%   -35.27%     
===========================================
  Files          16       17        +1     
  Lines        1792     1918      +126     
  Branches      317      340       +23     
===========================================
- Hits         1215      624      -591     
- Misses        497     1261      +764     
+ Partials       80       33       -47
Impacted Files Coverage Δ
src/pytest_benchmark/storage/s3.py 13% <13%> (ø)
src/pytest_benchmark/utils.py 37.21% <33.33%> (-29.38%) ⬇️
src/pytest_benchmark/table.py 15.18% <0%> (-74.69%) ⬇️
src/pytest_benchmark/fixture.py 15.92% <0%> (-65.93%) ⬇️
src/pytest_benchmark/timers.py 32.25% <0%> (-61.3%) ⬇️
src/pytest_benchmark/histogram.py 26.92% <0%> (-51.93%) ⬇️
src/pytest_benchmark/storage/file.py 25.49% <0%> (-41.18%) ⬇️
src/pytest_benchmark/stats.py 36.2% <0%> (-38.51%) ⬇️
src/pytest_benchmark/session.py 35.22% <0%> (-37.11%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dafa578...be6e000. Read the comment docs.

@vincentsarago
Copy link
Author

@ionelmc Sorry about the failing tests 🤦‍♂ hope the last commit will pass 🤞

@vincentsarago
Copy link
Author

Woaa, until yesterday I didn't know about iSort ... and now I understand why the tests were failling. Sorry about this @ionelmc . I hope it will be fine now

@ncclementi
Copy link

@vincentsarago Is this something still in the works? We are evaluating using pytest benchmark and having S3 storage would be a great pro.

@vincentsarago
Copy link
Author

@ncclementi it worked when I worked on this PR 😄
I haven't used it in a while so if there has been any update on the library this PR may need some update

@ncclementi
Copy link

@vincentsarago Yes, I noticed the branch has conflicts, but I'm not sure what's the maintainer's intention in getting this implemented. The PR seems to be very close to done, but it's been a while. Maybe @ionelmc can comment on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AWS S3 or HTTP storage
3 participants