-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add S3Storage #161
base: master
Are you sure you want to change the base?
add S3Storage #161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
===========================================
- Coverage 67.8% 32.53% -35.27%
===========================================
Files 16 17 +1
Lines 1792 1918 +126
Branches 317 340 +23
===========================================
- Hits 1215 624 -591
- Misses 497 1261 +764
+ Partials 80 33 -47
Continue to review full report at Codecov.
|
@ionelmc Sorry about the failing tests 🤦♂ hope the last commit will pass 🤞 |
Woaa, until yesterday I didn't know about iSort ... and now I understand why the tests were failling. Sorry about this @ionelmc . I hope it will be fine now |
@vincentsarago Is this something still in the works? We are evaluating using pytest benchmark and having S3 storage would be a great pro. |
@ncclementi it worked when I worked on this PR 😄 |
@vincentsarago Yes, I noticed the branch has conflicts, but I'm not sure what's the maintainer's intention in getting this implemented. The PR seems to be very close to done, but it's been a while. Maybe @ionelmc can comment on it? |
closes #160
To Do
cc @ionelmc