Add ability to specify listen variables through the environment #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionelmc
reviewed
Mar 4, 2019
README.rst
Outdated
|
|
||
| PYTHONBREAKPOINT=remote_pdb.set_trace REMOTE_PDB_HOST=0.0.0.0 REMOTE_PDB_PORT=10000 python script.py | ||
|
|
||
| Omitting either of these environment variables will use the default logic from above. |
There was a problem hiding this comment.
Hmmm. I'd reword this somehow, it doesn't sound right. Perhaps just state what the defaults are?
There was a problem hiding this comment.
I've reworked the whole section to try and be more explicit and be closer to the voice you used in the other parts of the readme. I'd originally tried to make this a light touch section to avoid restating things, but your idea of being explicit works for me.
use in Python3.7's breakpoint() more user friendly.
MatthewWilkes
force-pushed
the
environment_variables
branch
from
c882426 to
1ded754
Compare
|
Very good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 has a
breakpoint()built in to start the specified debugger. This change allows you to specify host and port details in the environment, so software that uses thebreakpoint()debugging convention can be run with remote-pdb without needing specific code changes and without having access to stdout.This helps with simplifying the learning journey for users on 3.8 when debugging complex multi-threaded or multi-process systems.
As with the other PR, please do ask if there's anything you want me to change or do differently.
Matt