feat(camera): Return if image was saved to gallery #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
changed the title
carlpoole
approved these changes
Sep 8, 2021
carlpoole
added a commit
that referenced
this pull request
Sep 15, 2021
* fix(camera): set settings again on callbacks (#595) * feat(storage): Add removeOld function (#585) * feat(camera): Return if image was saved to gallery (#599) * fix(camera): saveToGallery for edited images (#602) * docs(camera): Add descriptions to CameraSource (#608) * fix(local-notifications): return schedule on as object (#603) * chore(release): publish [skip ci] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] Co-authored-by: jcesarmobile <[email protected]> Co-authored-by: Ely Lucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment on iOS, if the user doesn't grant the gallery permission, we return the image even if it fails to save it to the gallery.
On Android, if the user doesn't grant the gallery permission in enters in an infinite loop of requesting the permission.
This PR unify the behaviour so on Android it returns the image even if it failed to save to to the gallery and prevents the infinite loop.
Additionally, on the returned object, it adds a saved property that will tell the user if the image was saved to the gallery or not.
closes #593