Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Documenting saving plugin calls #238

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Documenting saving plugin calls #238

merged 5 commits into from
Mar 9, 2021

Conversation

ikeith
Copy link
Contributor

@ikeith ikeith commented Feb 26, 2021

No description provided.

@ikeith ikeith requested review from elylucas and carlpoole February 26, 2021 22:59
@vercel
Copy link

vercel bot commented Feb 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

capacitor-site – ./

🔍 Inspect: https://vercel.com/ionic/capacitor-site/BCzxAEkKpo2Qfm63B3eQAvXa9pdb
✅ Preview: https://capacitor-site-git-saving-calls-ionic1.vercel.app

capacitor-docs – ./

🔍 Inspect: https://vercel.com/ionic/capacitor-docs/F9oC7WVWV9UtU4xKJTm8imLLfiTf
✅ Preview: Failed

[Deployment for 1829189 failed]

Copy link
Member

@carlpoole carlpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions for verbiage but I'll defer to your judgement and if anyone else has suggestions. The content is fine

pages/docs/v3/core-apis/saving-calls.md Outdated Show resolved Hide resolved
pages/docs/v3/core-apis/saving-calls.md Outdated Show resolved Hide resolved
pages/docs/v3/core-apis/saving-calls.md Outdated Show resolved Hide resolved
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the resolve/reject multiple times can be confusing, since the native methods can call the native reject/resolve multiple times, but the js promise can only be rejected/resolved once. I think it should mention that this multiple reject/resolve should be used with plugin callbacks (as geolocation)

@ikeith
Copy link
Contributor Author

ikeith commented Mar 8, 2021

@jcesarmobile I have tried to clarify between promises and callbacks.

@ikeith ikeith merged commit 436cd8e into main Mar 9, 2021
@ikeith ikeith deleted the saving-calls branch March 9, 2021 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants