Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cordova plugin (@batch.com/cordova-plugin) uses a static pod and isn't in the static list #5137

Closed
abarisain opened this issue Oct 14, 2021 · 6 comments · Fixed by #5138

Comments

@abarisain
Copy link

Bug Report

Hi!

I'm writing this on behalf of my company, Batch.com. We publish @batch.com/cordova-plugin, a Cordova plugin that is also explicitly compatible and tested with Ionic Capacitor.

Capacitor 3.2.5 seems to have broken our plugin, due to us distributing our framework as a static podspec. Our distribution being static is unlikely to change.

In #5099, you say that users will report static pods: this is us reporting one 😊. Unfortunately, the podspec format doesn't seem to enable us from providing the information whether we use a static pod or not.
If it helps, we'd be open to modifying our package.json to include metadata that Capacitor could read.

I didn't test if being in the static pod would fix the issue, as this would require me to patch the CLI.

Interesting tidbit: This is only a problem with Cocoapods 1.11. With 1.10, I cannot reproduce the issue and the app seems to load fine (didn't test it much, it's probably broken, but it compiles).

Capacitor Version

💊   Capacitor Doctor  💊

Latest Dependencies:

  @capacitor/cli: 3.2.5
  @capacitor/core: 3.2.5
  @capacitor/android: 3.2.5
  @capacitor/ios: 3.2.5

Installed Dependencies:

  @capacitor/android: not installed
  @capacitor/cli: 3.2.5
  @capacitor/ios: 3.2.5
  @capacitor/core: 3.2.5

[success] iOS looking great! 👌

Platform(s)

iOS

➜ pod --version
1.11.2

Current Behavior

Pod install fails with [!] The 'Pods-App' target has transitive dependencies that include statically linked binaries: (/private/tmp/myApp/ios/App/Pods/Batch/Batch.xcframework)

Expected Behavior

It should install properly

Code Reproduction

Run the following:

ionic start myApp
cd myApp
ionic build
ionic cap add ios
npm i @batch.com/cordova-plugin
ionic cap sync
@abarisain
Copy link
Author

Thanks!

@nowrap
Copy link

nowrap commented Oct 15, 2021

The same happens with the onesignal-cordova-plugin:
OneSignal/OneSignal-iOS-SDK#1012

@jcesarmobile
Copy link
Member

@nowrap can you create a new issue and provide a sample project? I can't reproduce

@nowrap
Copy link

nowrap commented Oct 15, 2021

Sure, but i need a bit time

@nowrap
Copy link

nowrap commented Oct 15, 2021

I created a new issue and could reproduce the behaviour with a project from scratch:
#5142

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 10, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants