bug: onesignal - The 'Pods-App' target has transitive dependencies that include

[nowrap]

Bug Report

Capacitor Version

💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 3.2.5
  @capacitor/core: 3.2.5
  @capacitor/android: 3.2.5
  @capacitor/ios: 3.2.5

Installed Dependencies:

  @capacitor/android: not installed
  @capacitor/cli: 3.2.5
  @capacitor/core: 3.2.5
  @capacitor/ios: 3.2.5

[success] iOS looking great! 👌

Platform(s)

ios

Current Behavior

A npx cap sync creates this error:

[!] The 'Pods-App' target has transitive dependencies that include
statically linked binaries:
(/mobileapp/ios/App/Pods/OneSignal/iOS_SDK/OneSignalSDK/Framework/OneSignal.framework)

This is related to:
#5099
#5137

A downgrade to @capacitor/cli version 3.2.4 solves this issue

Expected Behavior

That the sync runs without error

Code Reproduction

Assuming cocoapods are installed and synced:

ionic start myApp tabs --type vue

cd myApp
npm install @capacitor/ios
npx cap add ios

npm install onesignal-cordova-plugin@2

npm run build
npx cap sync

Other Technical Details

npm --version output: 8.1.0

node --version output: v14.18.1

pod --version output (iOS issues only): 1.11.2

macOS: 11.6

xcode: 13.0

Additional Context

[jcesarmobile]

I can reproduce now, I was installing version 3 and the issue is not reproducible there.
We can't really filter per plugin version, so I'll just add it anyway despite it's not needed for version 3.

[nowrap]

Ok, thx, for testing and adding.
Version 3 is the latest of the onesignal plugin but we didn't make the migration yet coz of the major changes.

Maybe it's an idea to create an option to add a plugin per project configuration somehow to this static exception list instead of having it globally defined in the cli project?

[nunoarruda]

I'm having the same issue 👇

How do we fix this for onesignal-cordova-plugin v2.x? I can't upgrade to onesignal-cordova-plugin v3.x just yet.

[jcesarmobile]

You have to wait for next Capacitor CLI release or downgrade to previous version

[nunoarruda]

This problem is back, at least for me, after upgrading @capacitor/cli from v3.3.1 to v3.3.2:

Git shows me that the CLI is trying to delete the following line in the Podfile:

Workaround: Downgrade @capacitor/cli to v3.3.1.

[jcesarmobile]

Please, when you find a bug, report an issue, don't comment on closed issues because they are not monitored, I usually unsubscribe after closing the issues.

In 3.3.2 we made the CLI to autodetect plugins that needs a static framework if they have use-frameworks="true" in the pods tag, and since OneSignal plugin had it, I removed it from the list.
But turns out version 2 didn't use the pods tag, so we'll need to put it back in the list.

Anyway, since 3.3.0 you can add any plugin you want to the static list from the capacitor config file without waiting for us to add it, you don't need to downgrade. Use the staticPlugins array inside the cordova object https://capacitorjs.com/docs/config

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.