-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): Plugin Registration and Plugin Instance Support #6072
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e006fc0
feat(ios): Adds support for manual registration for plugins and the
Steven0351 0eefe36
fix(ios): Add CAPPlugin+LoadInstance to xcodeproj to fix build errors
Steven0351 6dce602
Merge branch 'main' into ios-plugin-instance-support
Steven0351 842a1ff
Merge branch 'main' into ios-plugin-instance-support
Steven0351 299cb99
chore(ios): Add @objc annotation to CAPInstancePlugin and move its
Steven0351 e4a1eb9
Merge branch 'main' into ios-plugin-instance-support
Steven0351 d824539
Merge branch 'main' into ios-plugin-instance-support
Steven0351 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// | ||
// CAPPlugin+LoadInstance.swift | ||
// Capacitor | ||
// | ||
// Created by Steven Sherry on 11/9/22. | ||
// Copyright © 2022 Drifty Co. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
|
||
open class CAPInstancePlugin: CAPPlugin {} | ||
|
||
extension CAPPlugin { | ||
func load(as bridgedType: CAPBridgedPlugin.Type, on bridge: CAPBridgeProtocol) { | ||
self.bridge = bridge | ||
webView = bridge.webView | ||
pluginId = bridgedType.pluginId() | ||
pluginName = bridgedType.jsName() | ||
shouldStringifyDatesInCalls = true | ||
retainedEventArguments = [:] | ||
load() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed
pluginClassName
because it was no longer used. It being internal I removed it to avoid having to doNSStringFromClass
to pass in a value that wasn't used.