Fix bug where WKWebView doesn't respect the KeyboardDisplayRequiresUserAction setting #171
Conversation
…UserAction setting Fixes ionic-team#89 on cordova-plugin-wkwebview-engine ionic-team#89 Fixes #274 on ionic-plugin-keyboard ionic-team/ionic-plugin-keyboard#274
|
Can this be merged in? |
|
Thanks just merged |
|
This don't work on iOS 11.3 anymore!!! |
|
Has anyone fixed this yet? I’ve confirmed it’s also broken in 11.3
On Sat, Mar 31, 2018 at 2:33 PM Hirbod ***@***.***> wrote:
This don't work on iOS 11.3 anymore!!!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnm9eW1ID8isAET_LO_trgf_HJUoKMEks5tj8v6gaJpZM4O9owN>
.
--
Greg Avola
http://gregavola.me
(c) 508.596.8811
|
|
Yes I’ve fixed it. |
|
@gregavola and @mlynch also merged it into this repo, so just waiting for an official npm release and we won't have to rely on a third party plugin :) |
|
Fixed it in https://github.com/ionic-team/cordova-plugin-ionic-webview Are you able to use that one @gregavola? This specific plugin has been deprecated for a while, so cordova-plugin-ionic-webview is the new one |
|
@mlynch is it pushed npm? We use that one should it should be OK. |
|
@gregavola no, looks like I don't have access to that npm repo and it's Easter so that will have to wait until tomorrow. In the meantime the master branch is ready to go. Will publish 1.1.17 tomorrow |
|
Okay published 1.1.19 with this fix (in https://github.com/ionic-team/cordova-plugin-ionic-webview) |
|
Broken |
Fixes #89 on cordova-plugin-wkwebview-engine #89
Fixes #274 on ionic-plugin-keyboard ionic-team/ionic-plugin-keyboard#274