fix(SSR): class prop / state reactivity for target es2022 #6099
+241
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Changes introduced in #6076 caused a regression.
During SSR, the hydration script class Props built with es2022 were no longer reactive.
GitHub Issue Number:
Fixes #6095
What is the new behavior?
The class instance has been 're-wired' on the server (using the same method as the client).
Additionally, when testing, I noticed values set via Props during hydration would not go via custom decorators. This too has been fixed.
Documentation
Does this introduce a breaking change?
Testing
Other information