Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump svelty-picker from 3.6.1 to 5.0.0 #7381

Merged
merged 17 commits into from
Oct 19, 2023
Merged

chore(deps): bump svelty-picker from 3.6.1 to 5.0.0 #7381

merged 17 commits into from
Oct 19, 2023

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Aug 31, 2023 •
edited
Loading

Summary

bump svelty-picker version and cleanup DateTimePicker

Changelog

- Bump svelty-picker version to latest
- Remove unused css vars
- Cleanup DateTimePicker types and code composition

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

...

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@VmMad VmMad requested review from evavirseda and cpl121 August 31, 2023 09:20
@VmMad VmMad added the scope:dependencies Affects dependencies label Aug 31, 2023
begonaalvarezd
begonaalvarezd requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work, just added some comments

packages/shared/components/inputs/DateTimePicker.svelte Outdated Show resolved Hide resolved
packages/shared/components/inputs/DateTimePicker.svelte Outdated Show resolved Hide resolved
packages/shared/components/inputs/DateTimePicker.svelte Outdated Show resolved Hide resolved
packages/shared/components/inputs/DateTimePicker.svelte Outdated Show resolved Hide resolved
cpl121
cpl121 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VmMad VmMad marked this pull request as draft October 9, 2023 10:54
@VmMad VmMad changed the title chore(deps): bump svelty-picker from 3.6.1 to 4.1.4 chore(deps): bump svelty-picker from 3.6.1 to 5.0.0 Oct 9, 2023
@VmMad VmMad requested a review from cpl121 October 9, 2023 11:39
@VmMad VmMad marked this pull request as ready for review October 9, 2023 11:43
@VmMad VmMad mentioned this pull request Oct 9, 2023
Closed
cpl121
cpl121 requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The current date does not appear marked when I open the popup
Also, I have the application in English and the date appears in Spanish

@VmMad
Copy link
Member Author

VmMad commented Oct 18, 2023

image

The current date does not appear marked when I open the popup Also, I have the application in English and the date appears in Spanish

@cpl121 did you run yarn install before testing the PR? because I upgraded the version and the style variables changed and you probably didnt sync the package. For me the selected day shows up, and the problem with the spanish picker is the reactivity problem with i18n, because I didn't change anything and for me it shows in english. Try starting the dev server from zero. yarn && cd packages/desktop && yarn && yarn build && yarn start

Screenshot from 2023-10-18 10-45-37

@cpl121
Copy link
Member

cpl121 commented Oct 18, 2023

image
The current date does not appear marked when I open the popup Also, I have the application in English and the date appears in Spanish

@cpl121 did you run yarn install before testing the PR? because I upgraded the version and the style variables changed and you probably didnt sync the package. For me the selected day shows up, and the problem with the spanish picker is the reactivity problem with i18n, because I didn't change anything and for me it shows in english. Try starting the dev server from zero. yarn && cd packages/desktop && yarn && yarn build && yarn start

Screenshot from 2023-10-18 10-45-37

Yes, I have run the large command 🥲

cpl121
cpl121 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!! 🔥

@begonaalvarezd begonaalvarezd merged commit f90310c into develop Oct 19, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the chore/upgrade-svelty-picker branch October 19, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@evavirseda evavirseda Awaiting requested review from evavirseda

Assignees

@VmMad VmMad

Labels
scope:dependencies Affects dependencies
Projects
Firefly - Task Management
Status: 🎉 Done
Milestone
E02.M1 - Continuously improve security
Development

Successfully merging this pull request may close these issues.
3 participants
@VmMad @cpl121 @begonaalvarezd