Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Verify Address" button for Ledger Nano #7521

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Oct 3, 2023

Closes #7443

Summary

Add "Verify Address" button for Ledger Nano

Changelog

- Add "Verify Address" button for Ledger Nano

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

  • Enter a profile with ledger
  • In the wallet view click on the 3 dots and select Verify address
  • Check that the address that appears in the ledger is the same as the one seen in Firefly

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 marked this pull request as ready for review October 3, 2023 06:16
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 💪🏼 mini comments and we are ready

packages/shared/locales/en.json Outdated Show resolved Hide resolved
…op' of github.com:iotaledger/firefly into feat/add-verify-address-button-for-ledger
@cpl121 cpl121 requested a review from begonaalvarezd October 11, 2023 07:37
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@begonaalvarezd begonaalvarezd merged commit 8cb5111 into develop Oct 11, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-verify-address-button-for-ledger branch October 11, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add "Verify Address" button for Ledger Nano
2 participants