Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error when finding and claiming shimmer #7568

Merged
merged 3 commits into from
Oct 11, 2023
Merged

fix: error when finding and claiming shimmer #7568

merged 3 commits into from
Oct 11, 2023

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Oct 10, 2023 •
edited
Loading

Closes #7567

Summary

fix: error when finding and claiming shimmer

Changelog

- fix: error when finding and claiming shimmer

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 marked this pull request as ready for review October 10, 2023 11:18
brancoder
brancoder approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@begonaalvarezd begonaalvarezd merged commit 5a390e8 into develop Oct 11, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/error-when-claiming-shimmer branch October 11, 2023 12:06
This was referenced Oct 11, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancoder brancoder brancoder approved these changes

Assignees

@brancoder brancoder

@cpl121 cpl121

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Fix claiming shimmer
3 participants
@cpl121 @brancoder @begonaalvarezd