Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve balance finder #7582

Merged
merged 10 commits into from
Oct 19, 2023
Merged

feat: improve balance finder #7582

merged 10 commits into from
Oct 19, 2023

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Oct 11, 2023 •
edited
Loading

Closes #7577

Summary

Improve balance finder

Changelog

- Improve balance finder

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Go to Settings / Advanced
Click checkbox to search only with the current wallet and cick find balances button

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 marked this pull request as ready for review October 11, 2023 16:56
begonaalvarezd
begonaalvarezd requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requst changes with the comment above

@cpl121 cpl121 requested a review from begonaalvarezd October 16, 2023 11:02
@cpl121 cpl121 requested a review from begonaalvarezd October 18, 2023 10:36
@cpl121 cpl121 requested a review from begonaalvarezd October 19, 2023 15:22
@begonaalvarezd begonaalvarezd merged commit 7b9a529 into develop Oct 19, 2023
5 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/improve-balance-finder branch October 19, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Improve balance finder
2 participants
@cpl121 @begonaalvarezd