Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enhanced logic for identifying burned native tokens. #7584

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

brancoder
Copy link
Collaborator

@brancoder brancoder commented Oct 12, 2023

Summary

  • Refactor getBurnedNativeTokens logic for identifying burned native tokens.
  • Update logic to determine remainder in convertTransactionOutputTypeToWrappedOutput
  • Update logic getNonRemainderBasicOutputsFromTransaction to use remainder property

resolves #7107

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@brancoder brancoder marked this pull request as ready for review October 13, 2023 14:40
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!!
Works for me ✌🏼
image

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 💪🏼
Just a minor detail, I sent a native token to an NFT and it showed as burned 🙏🏼 https://explorer.shimmer.network/testnet/transaction/0xd348041e5134b5436bc7fe7df69da8e027c60eb5bce9d4d12775a47c698c6fce
image

@brancoder
Copy link
Collaborator Author

Very nice work 💪🏼 Just a minor detail, I sent a native token to an NFT and it showed as burned 🙏🏼 https://explorer.shimmer.network/testnet/transaction/0xd348041e5134b5436bc7fe7df69da8e027c60eb5bce9d4d12775a47c698c6fce image

Created a task for this issue #7617

@begonaalvarezd begonaalvarezd merged commit 46fb9a1 into develop Oct 18, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/burned-tx branch October 18, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Transfering native tokens to your own address shows as burned
3 participants