Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle implicit account not yet propagated to accounts legder #8261

Merged
merged 16 commits into from
Apr 3, 2024
Merged

feat: handle implicit account not yet propagated to accounts legder #8261

merged 16 commits into from
Apr 3, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #8246

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda linked an issue Mar 25, 2024 that may be closed by this pull request
[Task]: Better handle implicit account not yet propagated to accounts legder #8246
Closed
@evavirseda evavirseda marked this pull request as ready for review March 26, 2024 10:00
@cpl121 cpl121 self-requested a review March 26, 2024 13:03
cpl121 and others added 6 commits March 26, 2024 14:10
@cpl121
Merge branches 'feat/handle-implicit-account-not-yet-propagated-to-ac…
e03f615 
…count-ledger' and 'develop-iota2.0' of github.com:iotaledger/firefly into feat/handle-implicit-account-not-yet-propagated-to-account-ledger
@cpl121
fix: minor improvements
1ecc32d
@evavirseda
fix: jump into init route
39a3d84
@evavirseda
feat: improvements
286f93b
@cpl121
Merge branch 'develop-iota2.0' into feat/handle-implicit-account-not-…
dca5ef8 
…yet-propagated-to-account-ledger
@evavirseda
Merge branch 'develop-iota2.0' into feat/handle-implicit-account-not-…
f69fe1a 
…yet-propagated-to-account-ledger
@evavirseda evavirseda marked this pull request as draft March 27, 2024 11:50
@evavirseda evavirseda marked this pull request as ready for review April 3, 2024 10:32
cpl121
cpl121 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd merged commit 5aa3900 into develop-iota2.0 Apr 3, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/handle-implicit-account-not-yet-propagated-to-account-ledger branch April 3, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Better handle implicit account not yet propagated to accounts legder
3 participants
@evavirseda @begonaalvarezd @cpl121