Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mana to txs in tx activities and activity details #8263

Merged
merged 3 commits into from
Mar 27, 2024
Merged

feat: add mana to txs in tx activities and activity details #8263

merged 3 commits into from
Mar 27, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Mar 26, 2024

Closes #8099

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 linked an issue Mar 26, 2024 that may be closed by this pull request
[Task]: Add mana to txs in tx activities and activity details #8099
Closed
@begonaalvarezd begonaalvarezd merged commit e9e832b into fix/receive-funds-to-implicit-account-address Mar 27, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-mana-to-tx-history branch March 27, 2024 13:23
marc2332 added a commit that referenced this pull request Mar 28, 2024
@marc2332
Revert "feat: add mana to txs in tx activities and activity details (#…
13be349 
…8263)"

This reverts commit e9e832b.
@marc2332 marc2332 mentioned this pull request Mar 28, 2024
Merged
@marc2332 marc2332 restored the feat/add-mana-to-tx-history branch March 28, 2024 14:28
marc2332 added a commit that referenced this pull request Mar 28, 2024
@marc2332
Revert "feat: add mana to txs in tx activities and activity details (#…
a067fc1 
…8263)" (#8277)

This reverts commit e9e832b.
@marc2332 marc2332 mentioned this pull request Mar 28, 2024
Merged
10 tasks
begonaalvarezd added a commit that referenced this pull request Mar 28, 2024
@marc2332 @cpl121 @begonaalvarezd
fix: Receive funds to implicit account address (#8260)
e806be8 
* feat: Sync SDK types

* feat: stop generating txs out of outputs

* fix: tx history: include account output in average txs

* fix: Fix incorrect timestamp in Incoming txs

* fix: Receive funds to implicit account address

* feat: add mana to txs in tx activities and activity details (#8263)

Co-authored-by: Marc Espin <[email protected]>
Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>

* Revert "feat: add mana to txs in tx activities and activity details (#8263)" (#8277)

This reverts commit e9e832b.

---------

Co-authored-by: cpl121 <[email protected]>
Co-authored-by: cpl121 <[email protected]>
Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add mana to txs in tx activities and activity details
4 participants
@cpl121 @marc2332 @evavirseda @begonaalvarezd