Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add metrics #66

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Feat/add metrics #66

merged 1 commit into from
Dec 6, 2023

Conversation

LinZexiao
Copy link

@LinZexiao LinZexiao commented Dec 6, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #66 (e0bd044) into master (ce2d970) will increase coverage by 0.35%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   30.37%   30.73%   +0.35%     
==========================================
  Files           6        6              
  Lines         586      589       +3     
==========================================
+ Hits          178      181       +3     
  Misses        401      401              
  Partials        7        7              
Flag Coverage Δ
unittests 30.73% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
co/selector.go 82.14% <100.00%> (+0.32%) ⬆️

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 4dd17ab into master Dec 6, 2023
1 check passed
@simlecode simlecode deleted the feat/add-metrics branch December 6, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants