Feat/tanlang/replace client with api / 用封装好的 api 代替 httpClient #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinZexiao
force-pushed
the
feat/tanlang/replace-client-with-api
branch
from
22ec5b5 to
367e323
Compare
simlecode
reviewed
Jan 5, 2023
| @@ -21,43 +24,12 @@ func registerRoute(s *service.Service) http.Handler { | |||
| }) | |||
|
|
|||
| apiV0Group := router.Group("/api/v0") | |||
| Register(apiV0Group, s, service.IServiceStruct{}.Internal) | |||
There was a problem hiding this comment.
将路由和接口以及请求参数放到一起, 这样相比直接注册路由更加明了一些?
return err rather than panic when create client
diwufeiwen
reviewed
Jan 9, 2023
|
|
hunjixin
reviewed
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal Change