Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

feat: add Server-Timing headers #71

Merged
merged 2 commits into from
Apr 3, 2023
Merged

feat: add Server-Timing headers #71

merged 2 commits into from
Apr 3, 2023

Conversation

willscott
Copy link
Collaborator

@willscott willscott commented Apr 3, 2023

The middleware added on the request contexts enables caboose (filecoin-saturn/caboose#69) to print out sub-request timings.

cc #69

@willscott willscott requested a review from lidel April 3, 2023 12:53
@lidel lidel force-pushed the feat/dag-fetcher branch from b40fda9 to 95a81d8 Compare April 3, 2023 17:31
Base automatically changed from feat/dag-fetcher to main April 3, 2023 17:58
@lidel lidel force-pushed the feat/servertiming branch from 26503f9 to 11bba4d Compare April 3, 2023 18:06
@lidel lidel changed the title Add server-timing middleware to http server feat: add Server-Timing headers Apr 3, 2023
Copy link
Collaborator

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased to include merged #61 and latest caboose (incl. filecoin-saturn/caboose#69 and filecoin-saturn/caboose#70 added @aarshkshah1992)

Tested locally, header is passed, picked up by Firefox:

2023-04-03_20-52

Merging, so it's deployed as part of graph api.

@lidel lidel merged commit 0d22586 into main Apr 3, 2023
@lidel lidel deleted the feat/servertiming branch April 3, 2023 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants