This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 124
generic API #33
Merged
Merged
generic API #33
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
Generic API | ||
=========== | ||
|
||
#### `id` | ||
|
||
> Returns the identity of the Peer | ||
|
||
##### `Go` **WIP** | ||
|
||
##### `JavaScript` - ipfs.id([callback]) | ||
|
||
`callback` must follow `function (err, identity) {}` signature, where `err` is an error if the operation was not successful. `identity` is an object with the Peer identity. | ||
|
||
If no `callback` is passed, a promise is returned. | ||
|
||
Example: | ||
|
||
```js | ||
ipfs.id(function (err, identity) { | ||
if (err) { | ||
throw err | ||
} | ||
console.log(identity) | ||
}) | ||
``` | ||
|
||
#### `version` | ||
|
||
> Returns the implementation version | ||
|
||
##### `Go` **WIP** | ||
|
||
##### `JavaScript` - ipfs.version([callback]) | ||
|
||
`callback` must follow `function (err, version) {}` signature, where `err` is an error if the operation was not successful. `version` is an object with the version of the implementation, the commit and the Repo. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we add an example of the returned |
||
If no `callback` is passed, a promise is returned. | ||
|
||
Example: | ||
|
||
```js | ||
ipfs.version(function (err, version) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about all the options go has for version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They never really worked on the http-api level https://github.com/ipfs/js-ipfs-api/blob/master/test/interface-ipfs-core/version.spec.js#L8-L9, the filtering just happens on the CLI. |
||
if (err) { | ||
throw err | ||
} | ||
console.log(version) | ||
}) | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,4 +47,4 @@ | |
"greenkeeperio-bot <[email protected]>", | ||
"nginnever <[email protected]>" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/* eslint-env mocha */ | ||
/* eslint max-nested-callbacks: ["error", 8] */ | ||
|
||
'use strict' | ||
|
||
const expect = require('chai').expect | ||
|
||
module.exports = (common) => { | ||
describe('.generic', () => { | ||
let ipfs | ||
|
||
before(function (done) { | ||
// CI takes longer to instantiate the daemon, | ||
// so we need to increase the timeout for the | ||
// before step | ||
this.timeout(20 * 1000) | ||
|
||
common.setup((err, factory) => { | ||
expect(err).to.not.exist | ||
factory.spawnNode((err, node) => { | ||
expect(err).to.not.exist | ||
ipfs = node | ||
done() | ||
}) | ||
}) | ||
}) | ||
|
||
after((done) => { | ||
common.teardown(done) | ||
}) | ||
|
||
describe('callback API', () => { | ||
it('.id', (done) => { | ||
ipfs.id((err, res) => { | ||
expect(err).to.not.exist | ||
expect(res).to.have.a.property('id') | ||
expect(res).to.have.a.property('publicKey') | ||
done() | ||
}) | ||
}) | ||
|
||
it('.version', (done) => { | ||
ipfs.version((err, result) => { | ||
expect(err).to.not.exist | ||
expect(result).to.have.a.property('version') | ||
expect(result).to.have.a.property('commit') | ||
expect(result).to.have.a.property('repo') | ||
done() | ||
}) | ||
}) | ||
}) | ||
|
||
describe('promise API', () => { | ||
it('.id', () => { | ||
return ipfs.id() | ||
.then((res) => { | ||
expect(res).to.have.a.property('id') | ||
expect(res).to.have.a.property('publicKey') | ||
}) | ||
}) | ||
|
||
it('.version', () => { | ||
return ipfs.version() | ||
.then((result) => { | ||
expect(result).to.have.a.property('version') | ||
expect(result).to.have.a.property('commit') | ||
expect(result).to.have.a.property('repo') | ||
}) | ||
}) | ||
}) | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add an example to show what "Peer identity" means? Ie. the data that is returned.