This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Move dht tests from js-ipfs-api to interface-ipfs-core #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
interface-ipfs-core 0.18.3 released |
victorb
force-pushed
the
interface-core-dht-api
branch
from
33fa303 to
77bc8b1
Compare
|
current status in CI: Seems linting in interface-ipfs-core runs in different env than the tests for js-ipfs-api. |
| @@ -1,65 +1,18 @@ | |||
| /* eslint-env mocha */ | |||
| /* globals apiClients */ | |||
| 'use strict' | |||
There was a problem hiding this comment.
you shouldn't delete use strict
|
all right :) thank you @victorbjelkholm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs ipfs-inactive/interface-js-ipfs-core#36