This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
[WIP] refactor: use CID v1 with base32 encoding by default #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs ipfs/js-ipfs#1440 License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
added 2 commits
February 7, 2019 10:59
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
|
The CID v1 -> LGTM but I'll hold off merging until multiformats/js-cid/pull/73 is in and we can remove the git url from the |
This was referenced Feb 7, 2019
|
Will re-submit a new PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The module now creates and returns v1 CIDs which are base32 encoded by default. Also
rawLeavesis set totrueby default.refs ipfs/js-ipfs#1440
Interesting side effect - using CID v1 enables the
rawLeavesoption so the node sizes actually get smaller (I was expecting bigger nodes because of the extra version info in the CID of the links and didn't anticipaterawLeavesgetting enabled).