Initialization and webpack #10
Conversation
There was a problem hiding this comment.
@mitra42 As I wrote in the issue, I was not able to run this implementation as expected.
| * Clone the repo from here | ||
| * cd to ipfs-service-worker | ||
| * npm install | ||
| * cd examples |
There was a problem hiding this comment.
I think you intended to write examples/use-from-another-page
| * cd to ipfs-service-worker | ||
| * npm install | ||
| * cd examples | ||
| * npm run build |
There was a problem hiding this comment.
It is necessary a npm install previously, in order to install webpack
There was a problem hiding this comment.
I don't understand this, I am running npm install prior to the build, in the ipfs-service-worker.
To be honest, I think this example is much too complicated to be useful, though it helped me figure out how to do it myself. The example is completely unclear what "use-from-another-page" means and in my own implementation I've simplified it significantly to a single package.json, and a single webpack.config.js at the same level which builds the bundles in the dist directory.
I can't post that as a PR since its launching our own code (which includes IPFS) as the SW, rather than just IPFS.
There was a problem hiding this comment.
I agree with you that the example is pretty unclear.
I believe it may be considered as an independent project, with its own dependencies. In this PR, there are still 2 package.json. This way, with the implementation in this PR, it needs the npm install.
|
Should I close this Pull request, or is there something useful here you want to use? |
|
@diasdavid what do you think? |
|
@vasco-santos your call, if there are things here useful for #11 then pick those, if not, no need to merge it. Thanks @mitra42 for checking and testing this :) |
|
@diasdavid I think that we can close this issue. It has some important aspects that I will pick later |
This fixes the issues raised in #9 specifically.