-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitswap: reenable unit tests #327
Comments
What we want to do is going through trying to remove the Some flaky tests will be very hard to fix, it is fine to leave We can view coverage progress here: https://app.codecov.io/gh/ipfs/boxo/tree/main/bitswap |
Per sync with PL EngRes Bedrock on 2023-06-30, we'll update with where this sits in the queue (and expected completion date) by 2023-07-07. |
I signed off on 2023-07-07 without updating this - my bad. |
2023-10-05 conversation:
|
Recent improvements in bitswap should stabalize these tests. Closes #327
Recent improvements in bitswap should stabalize these tests. Closes #327
Done Criteria
Bitswap has tests reenabled such that we remove judgement from developers. CI must be green before we merge.
Why Important
In the absence of clear signal, developers have sometimes skipping CI checks, which in at least one instance caused a bug to go through.
Notes
This isn't intended to be a "fix the flaky tests" effort. For now we can just rerun the flaky tests X times. We need to get to a place though where all tests have to pass before we merge.
Internal conversation on this: https://filecoinproject.slack.com/archives/C04SWLJ2QQ4/p1684434613517719
The text was updated successfully, but these errors were encountered: