provider: second round of reprovider refactor #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #331 +/- ##
==========================================
+ Coverage 49.57% 50.60% +1.03%
==========================================
Files 283 281 -2
Lines 33873 33763 -110
==========================================
+ Hits 16792 17087 +295
+ Misses 15319 14893 -426
- Partials 1762 1783 +21
|
Jorropo
force-pushed
the
fix-deadlock-in-reprovider
branch
2 times, most recently
from
9b55dc8 to
a895637
Compare
Jorropo
force-pushed
the
fix-deadlock-in-reprovider
branch
from
a895637 to
8fb3d85
Compare
This revert the revert 4c5c98b and fixes a few deadlocks as well as include a required bump from `go-libp2p-routing-helpers`.
Jorropo
force-pushed
the
fix-deadlock-in-reprovider
branch
from
8fb3d85 to
6589b8b
Compare
Jorropo
changed the title
hacdias
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p-routing-helpers#74