This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix a startup race by creating the blockstoremanager process on init #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Feb 26, 2021
| @@ -26,24 +26,24 @@ func newBlockstoreManager(bs bstore.Blockstore, workerCount int) *blockstoreMana | |||
| bs: bs, | |||
| workerCount: workerCount, | |||
| jobs: make(chan func()), | |||
| px: process.WithTeardown(func() error { return nil }), | |||
| } | |||
| } | |||
|
|
|||
| func (bsm *blockstoreManager) start(px process.Process) { | |||
There was a problem hiding this comment.
I still need to make sure we shutdown the blockstoreManager when we shutdown the parent service (that's what the AddChild call does).
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
fix a startup race by creating the blockstoremanager process on init This commit was moved from ipfs/go-bitswap@d1d4afa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #464