Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing on Windows since both the value's being checked are not the same ones used on this platform.
Specifically, this causes
to always be false (on Windows).
The
Is
check I have in this patch is valid, but currently useless since we'll never receive that concrete value from the lock library.The string check should catch this error regardless.
I'm going to submit a patch to the lock library and see what they think about wrapping the error value.
We can wait on that and maybe include a dependency update with this PR if it goes through.