Update [email protected] #92
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
| @@ -196,7 +196,7 @@ type BlockData interface { | |||
| type IncomingRequestHookActions interface { | |||
| SendExtensionData(ExtensionData) | |||
| UsePersistenceOption(name string) | |||
| UseLinkTargetNodeStyleChooser(traversal.LinkTargetNodeStyleChooser) | |||
| UseLinkTargetNodePrototypeChooser(traversal.LinkTargetNodePrototypeChooser) | |||
There was a problem hiding this comment.
Note that there's a small change to the exported interface of this library. I applied the rename of s/NodeStyle/NodePrototype/ universally, for consistency.
There's no behavioral change, so any yet-further-downstream consumers should be able to literally apply that regexp when updating and be fine.
hannahhoward
force-pushed
the
updates
branch
from
bc2e83b to
3b96162
Compare
Simultaneously updates go-ipld-prime-proto, which also has changes to match that version of go-ipld-prime.
update to lastest needed sha for filecoin, reinstitute generated node tests
hannahhoward
force-pushed
the
updates
branch
from
be5620a to
f61f820
Compare
* Emit events with received cids (#71) * persist received cids on channel state. * Send, Receive and Validate Restart requests (#75) * Send, Receive and Validate Requests * Initiating and Responding Tests and bug fixes (#76) * Testing for resuming data transfer work * Cleanup Push Restarts PR (#79) * cleanup of restart PR * link the peers * Tests for pull restarts (#84) * tests for pull restarts * Merge Tests cleanup work (#92) * cleanup of restart PR * cleanup timedout channels (#93) * backward compatibility of restart (#96) * backward compatibility of restart * changes and tests * more tests * better error handling for restarts * feat(message): switch to cbor map encoding (#97) switch to cbor map encoding for the 1_1 message protocol * feat(channels): setup datastore migrations (#99) setup datatransfer channels so they migrate over successfully Co-authored-by: Hannah Howard <[email protected]>
Simultaneously updates go-ipld-prime-proto, which also has changes to match that version of go-ipld-prime.