-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
looks good. we'll need to wait for the pending ipld-prime PR to land since it changes a bit the encoder interface, right? |
we may consider releasing this as a v1.0 (semver major breaking release) and maintaining a branch for any needed patch fixes of the v0.x implementation. |
Note: I've reverted this PR in #31 to avoid breaking changes on master till they're ready. Please re-file it against a branch if you need it for something. |
…rime replace go-merkledag with go-fetcher This commit was moved from ipfs/go-ipfs-provider@7463091
…e_ipld_prime" This reverts commit bbafe76, reversing changes made to b8fd93c8e02bf176c5649b5684e535f51ae8686c. This commit was moved from ipfs/go-ipfs-provider@46797b1
Motivation
As part of a broader effort to use IPLD prime in IPFS, we want to start replacing read only usages of go-merkledag with go-fetcher. This PR replaces the usage of
merkledag.Walk
withfetcher.Session.BlockAll
to retrieve all links from a potentially remote Dag.