-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helia identifies itself to the network #122
Comments
JS used to be forbidden from overriding Firefox fixed it: https://bugzilla.mozilla.org/show_bug.cgi?id=1188932 So currently this isn't possible with 90-odd% of browsers. See CI failures in libp2p/js-ipni-content-routing#12 |
Thanks for the info @achingbrain . So I think to close this issue we do two things:
|
If the user has configured identify but not overridden the agent version, add helia and its version number to the string. Fixes #122
🎉 This issue has been resolved in version @helia/interface-v1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version helia-v1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done Criteria
Helia identifies itself to the network by default. Specifically this mean:
We want to also get the Helia version as well (e.g., “helia/vX.Y.Z”) just as Kubo does.
We should only set the "user agent" if a user hasn't specified an override one.
Why Important
This enables Helia's prevalence to be detected/measured. This is important for getting signal on Helia's adoption in production, which in turn affects things like:
Notes
The text was updated successfully, but these errors were encountered: