-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
window.ipfs: ipfs.cat does not return AsyncIterable #852
Comments
Thank you for reporting this! We are tracking migration to the new js-ipfs(-http-client) in #843, but due to limited bandwidth that won't happen in Q1. Should we disable window.ipfs until support for async iterables lands in Q2?@autonome @alanshaw I want to make a bugfix release and disable Y/n? |
re: disabling ipfs, it may be of use to end users to expose a means of asserting compatibility with a given js-ipfs semver string? i.e. to clarify |
This force-disables injection of window.ipfs and fades out the experiments on Preferences screen. We will restore it after move to JS API with Async Await and Async Iterables is finished. Context: #852 (comment) #843
This comment has been minimized.
This comment has been minimized.
Closing due to #589 (comment) |
I'm noticing some slightly odd behaviour when comparing js-ipfs with the ipfs-companion.
js-ipfs cat reliably returns
AsyncIterable
, but ipfs-companion sometimes returns aUint8Array
and sometimes returns some other function.generally, with the ipfs-companion enabled the page is stuck at ~110% CPU and frequently crashes or has to have it's task terminated.
Win 10, Chrome 80.0.3987.122, IPFS Companion 2.10.0
The text was updated successfully, but these errors were encountered: