Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a file with right click in explorer adds it to the MFS and pins it #1857

Closed
RubenKelevra opened this issue Jun 24, 2021 · 1 comment · Fixed by #1860
Closed

Adding a file with right click in explorer adds it to the MFS and pins it #1857

RubenKelevra opened this issue Jun 24, 2021 · 1 comment · Fixed by #1860
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@RubenKelevra
Copy link
Contributor

  • OS: Windows
  • Version of IPFS Desktop 0.16.0

Describe the bug
Adding files via right click in the explorer is pretty cool, but instead of adding the file just to the MFS, it is also locally pinned. Why?

I mean, the only reason to pin an item in the MFS is when it's lazily added via CID and you want it to be downloaded completly.

To Reproduce
Steps to reproduce the behavior:

  1. Add a file via right-click in explorer -> Add to ipfs
  2. Open the IPFS GUI

Screenshots
ipfs_desktop_screenshot_bugreport_imported_files_pinned
@RubenKelevra RubenKelevra added the need/triage Needs initial labeling and prioritization label Jun 24, 2021
@lidel
Copy link
Member

lidel commented Jun 24, 2021 •
edited
Loading

This is a bug, we should not pin it, adding to MFS is enough.
Should be 1 line fix.

@lidel lidel added exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up labels Jun 24, 2021
@lidel lidel removed the need/triage Needs initial labeling and prioritization label Jun 24, 2021
lidel added a commit that referenced this issue Jun 24, 2021
@lidel
fix: dont pin when adding to mfs
c68fd4f 
Closes #1857
@lidel lidel mentioned this issue Jun 24, 2021
Merged
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Jun 24, 2021
lidel added a commit that referenced this issue Jul 5, 2021
@lidel
fix: dont pin when adding to mfs (#1860)
7c4acf3 
Closes #1857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dont pin when adding to mfs ipfs/ipfs-desktop
2 participants
@lidel @RubenKelevra