feat: copy link to clipboard when adding to ipfs

[hacdias]

With this PR, we get back the feature of copying a shareable link to the clipboard when adding files to our node via the IPFS icon that sits on the menubar on macOS or to the shortcut of the app on Windows.

In addition, I cleaned up the locale messages, removing some that are not used anymore and updating the ones we have for this notification in particular. I will create a separate PR organizing the translation file a bit more.

We now add all files at once and give only one notification. If the user drops multiple files, we create an object linking to all of them, which is used for the shareable link and when clicking on the notification.

Closes #1218.

License: MIT
Signed-off-by: Henrique Dias [email protected]

[autonome]

Couple of minor things noted, but LGTM otherwise!

Separate thought about the PR structure - it bundled up two distinct changes: adding multiple files, and the clipboard change. This makes it a little bit slower to review and also reduces our ability to see clearly where problems are if some tests or something fail down the line and need to revert a change. For those reasons, generally I recommend separating features out into multiple PRs if possible. Sometimes the code is just too tangled to do that easily and I don't know the Desktop code very well, so ignore me if that's the case here!

[autonome]

For clarity, I think it would be nice to pull out cidAndPath into separate variables passed to sendNotification.

[hacdias]

Done!

[hacdias]

Thanks for your review @autonome! 😃

it bundled up two distinct changes: adding multiple files, and the clipboard change.

We already added multiple files, but not inside this function. We'd just call the function multiple times and get the same number of notifications as files, which would be annoying.

But yeah, I agree it could be separated into two PRs.

Sometimes the code is just too tangled to do that easily and I don't know the Desktop code very well, so ignore me if that's the case here!

Definitely, IPFS Desktop's code is too... not complex... but "well together"? 😆 There are a couple of things I'd like to adjust actually, but that's another matter.