Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup js-ipfs mentions #1620

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Cleanup js-ipfs mentions #1620

merged 11 commits into from
Jul 14, 2023

Conversation

ElPaisano
Copy link
Contributor

@ElPaisano ElPaisano commented Jun 13, 2023

WIP

As part of #1611, makes changes to ipfs-docs as described for each page in the Actions column of https://pl-strflt.notion.site/ipfs-docs-js-ipfs-cleanup-d46e22253bec4497865c38e7a9277eac

@SgtPooki @whizzzkid you should be able to contribute directly to this PR

@ElPaisano ElPaisano linked an issue Jun 13, 2023 that may be closed by this pull request
@BigLep BigLep marked this pull request as draft June 13, 2023 22:56
@BigLep
Copy link
Contributor

BigLep commented Jun 13, 2023

@ElPaisano : I'm converting to draft given its WIP. I'm happy to take a look once it has all the changes you intend to make.

@ElPaisano ElPaisano self-assigned this Jun 14, 2023
@SgtPooki SgtPooki mentioned this pull request Jun 14, 2023
2 tasks
@BigLep
Copy link
Contributor

BigLep commented Jul 12, 2023

Hi guys - this has been open for a few weeks. I'd like to find a more incremental approach so we can start removing js-ipfs mentions as we go rather than waiting for it all to be done.

@SgtPooki
Copy link
Member

SgtPooki commented Jul 13, 2023

@ElPaisano To address @BigLep's latest comment; How can we get these changes merged in faster?

We should merge this now if we can, or do whatever we can do be able to merge this more quickly.

@ElPaisano ElPaisano marked this pull request as ready for review July 14, 2023 00:34
@ElPaisano ElPaisano merged commit cb9e234 into main Jul 14, 2023
@ElPaisano ElPaisano deleted the js-ipfs-cleanup branch July 14, 2023 00:35
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. I couldn't do "suggestions" because this was already merged. @ElPaisano : are you ok to take on the followup review incorporating this feedback?

@@ -34,6 +35,20 @@ When you add a file to IPFS, IPFS splits it into smaller blocks. IPFS hashes eac

There are a lot of ways you can contribute to IPFS, whether you're interested in helping with either of the core implementations, applications like IPFS Desktop, writing or editing documentation, doing UX, or whatever you enjoy working on. [Get all the details on where to get started here.](../community/contribute/ways-to-contribute.md)

### What is an implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really be driving people towards https://specs.ipfs.tech in this section and particularly https://specs.ipfs.tech/architecture/


- Verifies that the CIDs it resolves match the resources they address, at least when it has access to the resources bytes. However, implementations may relax this requirement in controlled environments in which it is possible to ascertain that verification has happened elsewhere in a trusted part of the system.

There are already many IPFS implementations, including [Kubo](../install/command-line.md), [Helia](../install/js-ipfs.md), and [more](../concepts/ipfs-implementations.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better to link to the Kubo and Helia project pages.

Also is js-ipfs.md still a thing?

@@ -228,6 +228,10 @@ The sharding technique used for [sharding](#sharding) big UnixFS directories. It

A Cryptographic Hash is a function that takes some arbitrary input (content) and returns a fixed-length value. The exact same input data will always generate the same hash as output. There are numerous hash algorithms. [More about Hash](hashing.md)

### Helia

A lean, modular, and modern implementation of IPFS for the JS and browser environments. Superseded [js-ipfs](#js-ipfs). Learn more at [https://github.com/ipfs/helia](https://github.com/ipfs/helia).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It supersedes js-ipfs." (so we have a complete sentence)


#### Limitations of a bootstrap node:

- If an IPFS node only has one bootstrap node listed in that configuration and that bootstrap node goes offline, the IPFS node will lose access to the public DHT if it were to restart.
- If an IPFS _node_ only has one bootstrap _node_ listed in that configuration and that bootstrap node goes offline, the IPFS node will lose access to the public DHT if it were to restart.
- Note that you should be able to configure your _peer_ store in your implementation to cache healthy connectable _peers_ so you can connect to them again after a restart, instead of bootstrap _nodes_. [Kubo recently added support for this](https://github.com/ipfs/kubo/pull/8856).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubo has support this

"recent" is relative
I think better to link to the issue which has the context and links to the PR

@@ -5,7 +5,7 @@ description: Learn about the available node types in IPFS Companion.

# Understand node types in IPFS Companion

IPFS Companion's preferences screen allows you to choose from several different node types. The available types you'll see in your Companion preferences depends on the browser you're using (i.e. Firefox, Chrome, Brave), but the full list is as follows:
IPFS Companion's preferences screen allows you to choose from different node types. The available types you'll see in your Companion preferences depends on the browser you're using (i.e. Firefox, Chrome, Brave), but the full list is as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whizzzkid or @ElPaisano : per #1631 (comment) , we should update the screenshot here (or just remove the screenshot and referencing text).

@@ -102,29 +101,3 @@ ipfs name publish --key=SecondKey /ipfs/bafybeicklkqcnlvtiscr2hzkubjwnwjinvskffn

> Published to k51qzi5uqu5dh5kbbff1ucw3ksphpy3vxx4en4dbtfh90pvw4mzd8nfm5r5fnl: /ipfs/bafybeicklkqcnlvtiscr2hzkubjwnwjinvskffn4xorqeduft3wq7vm5u4
```

## Publishing IPNS names programmatically with JS-IPFS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe give a link to https://github.com/ipfs/helia-ipns for doing IPNS with JS?

(A side issue is that that repo needs to have a usage example: ipfs/helia-ipns#59 )

@ElPaisano
Copy link
Contributor Author

Thanks for reviewing @BigLep these comments are being addressed in #1639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog and figure out what to do with js-ipfs content
4 participants