-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document config initialization with envs #856
Conversation
Documentation of feature from ipfs/kubo#8326
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help here @vk496. I've made some minor tweaks.
Blocked
Gonna wait on ipfs/kubo#8326 before this gets merged.
Thank you @johnnymatthews Just one thing that I was not sure how to deal: indicate minimum required version. Most Docker users expect environment override as a basic feature. They will see the instructions for using it and would try it, in the best case, with the latest stable version (which will not do what they expect and not fail) |
Minimum version of IPFS? Or Docker? Or both? |
Docker images of IPFS. https://hub.docker.com/r/ipfs/go-ipfs/tags |
We decided on a different approach, as this one had some gaps. |
Documentation of feature from ipfs/kubo#8326