Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Blocked loading mixed active content on https://webui.ipfs.io #925

Closed
Gozala opened this issue Jan 5, 2019 · 2 comments
Closed
Assignees
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@Gozala
Copy link
Contributor

Gozala commented Jan 5, 2019

There must be some invalid assumption about the host in some URL resolution because the following error appears when using webui from https://webui.ipfs.io which does not appear when loading from http://127.0.0.1:5001/webui/ give the URL blocked I think there is assumption that protocol schema is http: which or maybe expectation that there address contains a port.

screen shot 2019-01-04 at 4 39 24 pm

@olizilla
Copy link
Member

olizilla commented Jan 7, 2019

Thanks for reporting that. It's a bug in ipfs-redux-bundle where it checks for an IPFS api at the same origin that the site was loaded from, and in uri-to-multiaddr, where it converts the current origin into a mutliaddr. I'll take a look.

@olizilla olizilla self-assigned this Jan 7, 2019
@olizilla olizilla added kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up exp/intermediate Prior experience is likely helpful labels Jan 7, 2019
@olizilla olizilla mentioned this issue Jan 7, 2019
10 tasks
olizilla added a commit to ipfs-inactive/ipfs-redux-bundle that referenced this issue Jan 25, 2019
olizilla added a commit to ipfs-inactive/ipfs-redux-bundle that referenced this issue Feb 6, 2019
fixes ipfs/ipfs-webui#925

License: MIT
Signed-off-by: Oli Evans <[email protected]>
olizilla added a commit to ipfs-inactive/ipfs-redux-bundle that referenced this issue Feb 18, 2019
You have to explicitly pass the protocol to the ipfs-http-client constructor

Depends on
- multiformats/js-uri-to-multiaddr#3
- ipfs-inactive/js-ipfs-http-client#935

Fixes ipfs/ipfs-webui#925


License: MIT
Signed-off-by: Oli Evans <[email protected]>
olizilla added a commit that referenced this issue Feb 18, 2019
- Update ipfs-redux-bundle ipfs-inactive/ipfs-redux-bundle#24

Fixes #925

License: MIT
Signed-off-by: Oli Evans <[email protected]>
olizilla added a commit that referenced this issue Feb 18, 2019
- Update ipfs-redux-bundle ipfs-inactive/ipfs-redux-bundle#24

Fixes #925

License: MIT
Signed-off-by: Oli Evans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

2 participants