fix: peers page with /p2p-websocket-star addrs #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <[email protected]>
lidel
requested changes
Nov 12, 2019
There was a problem hiding this comment.
I am still getting Error: Invalid ip address: ws-star.discovery.libp2p.io, same as in #1287.
@hacdias try adding unit tests for isPrivateAndNearby and test it against multiaddrs like:
/dnsaddr/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star/ipfs/QmbJbcN3Fvy5bC7Tr95STx5VFiP1G1WLPCHNceh1yShfbb
/dns4/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star/ipfs/QmYy3ka6HsQzpdTXY63nUKShsVdgg5zdhMXZXFeNGPyMT4
License: MIT Signed-off-by: Henrique Dias <[email protected]>
|
@lidel apparently, those errors were not only be emitted from Just fixed it and added a bunch of tests! |
lidel
approved these changes
Nov 12, 2019
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1287 by checking if
addr.addressis an actual IP.License: MIT
Signed-off-by: Henrique Dias [email protected]