fix: view in gateway url now validates if url is acessible #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Aug 17, 2020
lidel
requested changes
Aug 18, 2020
lidel
requested changes
Aug 20, 2020
lidel
requested changes
Aug 26, 2020
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
rafaelramalho19
force-pushed
the
fix/view-in-gateway-url
branch
from
47f52ff to
dd6ac9d
Compare
lidel
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
LGTM!
I was about to add a note how to address #1490 in a way that accounts for all edge cases and I ended up implementing it in pseudocode, so I just added it in 7c8b455 to this PR 🙃 – hope that's ok!
@rafaelramalho19 take a look if mentioned commit makes sense
|
LGTM @lidel, thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1490