-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it work with js-ipld 0.18.0 #5
Comments
This kind of blocks me as there's more breaking changes for js-ipld (ipld/js-ipld#163, ipld/js-ipld#164) which I'd like to release. But I think fixing this one first would make sense. I think I can fix the upcoming breakage myself. |
I think the only change needed here https://github.com/ipfs-shipyard/ipld-explorer-components/blob/master/src/lib/normalise-dag-node.js#L87-L115. |
vmx
added a commit
that referenced
this issue
Oct 25, 2018
The API for [dag-cbor](https://github.com/ipld/js-ipld-dag-cbor) changed. Links are no longer represented as JSON objects (`{"/": "base-encoded-cid"}`, but as [CID objects](https://github.com/ipld/js-cid). Closes #5.
vmx
added a commit
that referenced
this issue
Oct 25, 2018
The API for [dag-cbor](https://github.com/ipld/js-ipld-dag-cbor) changed. Links are no longer represented as JSON objects (`{"/": "base-encoded-cid"}`, but as [CID objects](https://github.com/ipld/js-cid). Closes #5.
vmx
added a commit
that referenced
this issue
Nov 2, 2018
The API for [dag-cbor](https://github.com/ipld/js-ipld-dag-cbor) changed. Links are no longer represented as JSON objects (`{"/": "base-encoded-cid"}`, but as [CID objects](https://github.com/ipld/js-cid). Closes #5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
js-ipld 0.18.0 had a breaking change in regards to CBOR nodes. They no longer encode links as JSON (
{"/": "base-encoded-cid"}
), but returns directly a CID. For more information see https://github.com/ipld/js-ipld/blob/f1c2e12abff5a17c24ba142f2d6b61429c573d97/CHANGELOG.md#0180-2018-10-12.I'd expect the other formats will follow and return links as CID objects.
The text was updated successfully, but these errors were encountered: