Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "feat: http upload/download progress handlers" #58

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

achingbrain
Copy link
Member

Reverts #54 - see #54 (comment)

  • XHR cannot do streaming downloads so breaks browser pubsub

BREAKING CHANGE: Removes onUploadProgress and onDownloadProgress options

@Gozala
Copy link
Contributor

Gozala commented Aug 18, 2020

I have created #60 to address the pubsub issue.

@hugomrdias hugomrdias merged commit 1bbe957 into master Aug 18, 2020
@hugomrdias hugomrdias deleted the revert-54-xhr branch August 18, 2020 12:13
Gozala pushed a commit that referenced this pull request Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants